if statement ignoring it’s condition in C?

by

Summary

The issue at hand is an incorrect filtering of vehicles based on their marca (brand) in a C program. The code is intended to print only the vehicles that match a specific brand, but instead, it prints the entire list of vehicles. This problem is reproducible and consistent, indicating a logical error in the code.

Root Cause

The root cause of this issue lies in the procurarVeiculoMarca function, which is responsible for finding the position of a vehicle with a matching marca. The function uses strcmp to compare the marca of each vehicle with the target marca. However, the converteMaiuscula function is used to convert the target marca to uppercase, but the marca of each vehicle is not converted to uppercase. This case sensitivity issue causes the strcmp function to return non-zero values, even when the marca matches.

Why This Happens in Real Systems

This issue can occur in real systems due to:

  • Inconsistent data formatting: When data is not formatted consistently, comparisons may not work as expected.
  • Case sensitivity: Many programming languages, including C, are case-sensitive, which can lead to unexpected behavior if not handled properly.
  • Lack of input validation: Failing to validate user input can cause issues like this, where the program does not behave as expected due to incorrect or inconsistent input.

Real-World Impact

The impact of this issue can be significant, including:

  • Incorrect results: The program may produce incorrect results, which can lead to inaccurate decisions or actions.
  • User frustration: Users may become frustrated with the program’s behavior, leading to negative feedback and low adoption rates.
  • Maintenance challenges: Debugging and maintaining the program can be more difficult due to the complexity and inconsistency of the code.

Example or Code

int procurarVeiculoMarca(tipoVeiculo vetorVeiculos[MAX_VEICULOS], int quantVeiculos, char marca[]) {
    int posicao, i;
    posicao = -1;
    for (i=0; i < quantVeiculos; i++) {
        // Convert both marca to uppercase for comparison
        char marcaUpper[TEXTO_CURTO];
        strcpy(marcaUpper, vetorVeiculos[i].marca);
        converteMaiuscula(marcaUpper);
        if (strcmp(marcaUpper, marca) == 0) {
            posicao = i;
            i = quantVeiculos;
        }
    }
    return posicao;
}

How Senior Engineers Fix It

Senior engineers would fix this issue by:

  • Identifying the root cause: Using debugging tools and techniques to identify the source of the problem.
  • Validating input: Ensuring that user input is validated and formatted consistently.
  • Using case-insensitive comparisons: Converting both strings to uppercase or lowercase before comparing them.
  • Testing thoroughly: Testing the program with different inputs and scenarios to ensure it behaves as expected.

Why Juniors Miss It

Junior engineers may miss this issue due to:

  • Lack of experience: Limited experience with programming and debugging can make it harder to identify and fix complex issues.
  • Insufficient testing: Failing to test the program thoroughly can lead to overlooking issues like this.
  • Inadequate understanding of case sensitivity: Not fully understanding how case sensitivity works in programming languages can lead to unexpected behavior.

Leave a Comment